Skip to content

Update OpenAiApi.java gpt model versions #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

youngmoneee
Copy link
Contributor

While exploring the OpenAiApi class, I identified some areas for improvement within the ChatModel and ChatCompletionFinishReason enums and proceeded with the following adjustments:

  • I updated the version in ChatModel from gpt-3.5-turbo-1106 to gpt-3.5-turbo-0125.
  • I corrected a typo in ChatCompletionFinishReason, changing TOOL_CAL to TOOL_CALL.

@youngmoneee youngmoneee marked this pull request as ready for review March 5, 2024 08:58
@youngmoneee youngmoneee closed this Mar 5, 2024
@youngmoneee youngmoneee reopened this Mar 5, 2024
@markpollack
Copy link
Member

markpollack commented Mar 6, 2024

I think that since the gpt-3.5-turbo will always point to the "unpinned" gpt-3.5-turbo model. However, users may still want to explicitly specify by name the model they want to use, even if at some point in time it matches the model that is the alias for gpt-3.5-turbo model. I'll update the PR to add the new version instead of replace the older one.

@tzolov tzolov added this to the 0.8.1 milestone Mar 6, 2024
Maintain the existing version
@youngmoneee
Copy link
Contributor Author

I think that since the gpt-3.5-turbo will always point to the "unpinned" gpt-3.5-turbo model. However, users may still want to explicitly specify by name the model they want to use, even if at some point in time it matches the model that is the alias for gpt-3.5-turbo model. I'll update the PR to add the new version instead of replace the older one.

I've made modifications to keep the existing version without removing it

@markpollack markpollack changed the title Update OpenAiApi.java Update OpenAiApi.java gpt model versions Mar 6, 2024
@markpollack
Copy link
Member

merged in 7396597 Thanks!

@markpollack markpollack closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants